feat: add timestamp offset by slice for persistence queries #32479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Aug 15, 2024
| * @param offsets | ||
| * Map of TimestampOffset by slice | ||
| */ | ||
| final class TimestampOffsetBySlice private (val offsets: Map[Int, TimestampOffset]) extends Offset { |
There was a problem hiding this comment.
add serialization of it to QuerySerialization
There was a problem hiding this comment.
Ok. Should only be used on init I guess, not in envelopes, but makes sense to have coverage. So that's a string-based serialization format? I'll take a look. Maybe double the timestamp offset separator with ;;.
There was a problem hiding this comment.
Added serialization. Uses ;; for separator between entries, and ; between each slice and its encoded timestamp offset.
pvlugter
commented
Aug 16, 2024
| val str = new java.lang.StringBuilder | ||
| if (offsetBySlice.offsets.nonEmpty) { | ||
| var first = true | ||
| offsetBySlice.offsets.foreach { |
There was a problem hiding this comment.
Seen map in timestamp offset is sorted by pid first. Could do something similar here, and sort by slice if it's useful to have it in stable order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For persistence stores that have separate queries per slice.