chore: Drop scala java8 compat #32435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
approved these changes
Jun 10, 2024
|
This should wait until the last responsible moment before the Akka 2.10 version. |
|
We will not make such dependency change in a patch version, but it would be fine for Akka 2.10. Let's wait with merging so that we don't have to maintain double branches, for a while more. |
|
I have created branch |
sebastian-alfers
force-pushed
the
drop-scala-java8-compat
branch
from
2361054
to
9db99e7
Compare
johanandren
reviewed
Sep 3, 2024
👍 Will rebase and add. |
sebastian-alfers
force-pushed
the
drop-scala-java8-compat
branch
from
e960e6c
to
f25215e
Compare
johanandren
approved these changes
Sep 3, 2024
patriknw
approved these changes
Sep 3, 2024
|
|
||
| ## Remove dependency to scala-java8-compat | ||
|
|
||
| The transitive dependency on `scala-java8-compat` has been removed. |
| @@ -43,7 +43,7 @@ public void useCircuitBreakerWithCompletableFuture() throws Exception { | |||
| assertEquals( | |||
| "hello", | |||
| Await.result( | |||
| FutureConverters.toScala(res), JavaDurationConverters.asFiniteDuration(fiveSeconds))); | |||
| FutureConverters.asScala(res), JavaDurationConverters.asFiniteDuration(fiveSeconds))); | |||
There was a problem hiding this comment.
In a separate PR you could try to remove akka.util.JavaDurationConverters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.