fix: Regression in parsing arbitrary pem file blocks #32399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For parsing EDCSA a pem file contains multiple blocks, I caused a regression by only extracting private keys to support that in #32341 however the pem parser allowed reading arbitrary pem blocks before that.
This fixes the regression and allows for reading arbitrary entries again, to support the EDCSA use case it introduces a separate few APIs to read all pem entries, and hand a sequence of entries to the DerPrivateKeyLoader to load the first supported private key or fail if none exists.