-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Include more samples #32387
doc: Include more samples #32387
Conversation
run: |- | ||
cd samples/akka-sample-kafka-to-sharding-scala | ||
sbt test -Dakka.version=`cat ~/.version` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following are not moved (and will not have a replacement):
- akka-sample-cluster-client-grpc-java
- akka-sample-cluster-client-grpc-scala
- akka-sample-cqrs-java
- akka-sample-cqrs-scala
- akka-sample-distributed-workers-scala
- akka-sample-persistence-dc-java
- akka-sample-persistence-dc-scala
- akka-sample-persistence-java
- akka-sample-persistence-scala
@@ -33,11 +29,6 @@ You can use both Akka remoting and Akka Cluster inside Docker containers. Note | |||
that you will need to take special care with the network configuration when using Docker, | |||
described here: @ref:[Akka behind NAT or in a Docker container](../remoting-artery.md#remote-configuration-nat-artery) | |||
|
|||
You can look at the | |||
@java[@extref[Cluster with docker-compse example project](samples:akka-sample-cluster-docker-compose-java)] | |||
@scala[@extref[Cluster with docker-compose example project](samples:akka-sample-cluster-docker-compose-scala)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not worth keeping that sample
@@ -13,10 +13,6 @@ To take advantage of running inside Kubernetes while forming a cluster, | |||
@extref:[Akka Cluster Bootstrap](akka-management:bootstrap/) helps forming or joining a cluster using Akka Discovery to discover peer nodes. | |||
with the Kubernetes API or Kubernetes via DNS. | |||
|
|||
You can look at the | |||
@extref[Cluster with Kubernetes example project](samples:akka-sample-cluster-kubernetes-java) | |||
to see what this looks like in practice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be included in "Deploying Akka Cluster to Kubernetes", which is linked above
* move samples from https://github.com/akka/akka-samples and include zip files in docs
6207a11
to
bc6bf25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
On top of #32384