doc: Zip download of hello world (quickstart) sample #32384
Conversation
patriknw
commented
Apr 17, 2024
patriknw
commented
- moving away sample downloads from developer.lightbend.com
- include zip downloads of samples in Paradox
- this is the same sample as we have in "First example" so the doc content of the quickstart is redundant
- updated links from getting started
- test samples from ci
* moving away sample downloads from developer.lightbend.com * include zip downloads of samples in Paradox * this is the same sample as we have in "First example" so the doc content of the quickstart is redundant * updated links from getting started * test samples from ci
.github/workflows/check-samples.yml
Outdated
| name: Check samples | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
we should probably change this to run on merge to main instead of pr validation
| ``` | ||
| or | ||
| ``` | ||
| ./gradlew run |
There was a problem hiding this comment.
do we want to include gradle or not?
There was a problem hiding this comment.
For: we already have it, against: we don't really maintain the gradle/keep it up to date
| ``` | ||
| or | ||
| ``` | ||
| ./gradlew run |
There was a problem hiding this comment.
For: we already have it, against: we don't really maintain the gradle/keep it up to date
| - name: Test akka-quickstart-java | ||
| run: |- | ||
| cd samples/akka-quickstart-java | ||
| mvn test -nsu -ntp -Dakka.version=`cat ~/.version` |
There was a problem hiding this comment.
Do we see any disadvantage of bringing in more/all of the samples from https://github.com/akka/akka-samples into the core repositories, like this?
There was a problem hiding this comment.
I think we can do that but a bit selectively, not sure all samples there are providing any value
