Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary todo from DurableDataSpec #32239

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Remove unnecessary todo from DurableDataSpec #32239

merged 1 commit into from
Nov 27, 2023

Conversation

Captain1653
Copy link
Contributor

@Captain1653 Captain1653 commented Nov 25, 2023 •
edited
Loading

A little suggestion :) .

I was checking todo items in the project and found this.

It was added long time ago.

It's hard to understand the meaning. Should it be deleted or should be added some additional information?

patriknw
patriknw approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure what the intention with that fixme was. Maybe the log.debug was just something temporary. I think you can remove the log statement as well.

@Captain1653
Copy link
Contributor Author

Done :)

octonato
octonato approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonato octonato merged commit b23f339 into akka:main Nov 27, 2023
5 checks passed
@octonato octonato added this to the 2.9.1 milestone Nov 27, 2023
@Captain1653 Captain1653 deleted the durable-data-spec-todo branch November 27, 2023 13:10
He-Pin pushed a commit to He-Pin/akka that referenced this pull request Jan 7, 2024
@Captain1653 @He-Pin
Remove unnecessary todo from DurableDataSpec (akka#32239)
c6c3e7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriknw patriknw patriknw approved these changes

@octonato octonato octonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Captain1653 @patriknw @octonato