chore: fix logging for optional snapshots when deleting events #32227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
Nov 10, 2023
|
But I'm, just like you, not entirely sure it will ever reach that point with that initial check in place. |
patriknw
reviewed
Nov 10, 2023
...-persistence-typed/src/main/scala/akka/persistence/typed/internal/ExternalInteractions.scala
Show resolved
Hide resolved
He-Pin
pushed a commit
to He-Pin/akka
that referenced
this pull request
Jan 7, 2024
…32227) * chore: fix logging for optional snapshots when deleting events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, optional refers to fact if loading a snapshot is allowed to fail.
It may even be that this logging is currently not triggered based on this condition: https://github.com/akka/akka/blob/main/akka-persistence-typed/src/main/scala/akka/persistence/typed/internal/BehaviorSetup.scala#L79-L86