-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add JDK 21 to nightly builds #32226
Conversation
Huh, coursier in the CI job doesn't find temurin:1.21.0.1, but I can download that on my local machine using coursier. 🤔 |
Green test run here: https://github.com/akka/akka/actions/runs/6796437075 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are we keeping JDK11 for a while?
@@ -88,6 +88,7 @@ jobs: | |||
# leaving out some combinations (note that `build-test-prValidations.yml` doesn't run all test | |||
- { scalaVersion: "2.13", jdkVersion: "1.11.0", jvmName: "temurin:1.11.0", extraOpts: '' } | |||
- { scalaVersion: "2.13", jdkVersion: "1.17.0", jvmName: "temurin:1.17.0", extraOpts: '' } | |||
- { scalaVersion: "2.13", jdkVersion: "1.21.0", jvmName: "temurin:1.21", extraOpts: '' } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about scala3 with jdk 21?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, PR validation is still using jdk11.
Maybe time to move to jdk17 and keep jdk11 only in the nightly build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good to keep the oldest as default because then we catch if a PR uses new JDK (and Scala) stdlib issues directly instead of not until the nightlies.
Not sure if it is worth it with one more build for JDK 21 or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge and we can follow up adding Scala 3 JDK 21 to the matrix if we decide we want it.
No description provided.