MiMa for 2.7.0 and JDK9 classes #31693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered something strange when trying to bump MiMa check to cover 2.7.0:
The MiMa plgin looks at classes in a single directory (
mimaCurrentClassfiles), but our tricky JDK9+ only sources setup compile to a different directory undertarget/(target/scala-2.13/CompileJdk9-classesvs the usualtarget/scala-2.13/classes).This should mean that MiMa never covered those JDK9+ classes, however MiMa didn't fail until we added 2.7.0 to the MiMa check. I haven't been able to figure out why it didn't fail before with what to MiMa looks like classes being removed.
To workaround this I've added another plugin which is triggered by the JDK9 plugin and merges the regular class directory and the Jdk9 class directory into a separate directory, only for mima to do its binary compatibility check on.
Verified by triggering mima failures in both regular classes and JDK9 only classes.