Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(parseRawCommit): allow for lack of S or : #54

Closed
wants to merge 1 commit into from
Closed

feat(parseRawCommit): allow for lack of S or : #54

wants to merge 1 commit into from

Conversation

PatrickJS
Copy link

we are human after all

angular/angular#2058

updated regexp
https://regex101.com/r/wZ2oK2/1

@PatrickJS PatrickJS mentioned this pull request May 21, 2015
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+3.68%) to 92.11% when pulling ddddf0f on gdi2290:patch-1 into 85cad9b on ajoslin:master.

@stevemao
Copy link
Member

Hi @gdi2290 Thanks for the PR

However, I'm not planning to look at the current version anymore and I want to roll out the next version as quickly as possible. So can you take a look at #51? Thanks again.

@stevemao
Copy link
Member

BTW, I think this issue is fixed in the upcoming release but do checkout.

Ref: conventional-changelog-archived-repos/conventional-commits-parser#3

@stevemao stevemao closed this in 7c48e0d Jun 11, 2015
@stevemao
Copy link
Member

Please checkout the rewrite on the master branch and see if the problem still exists. Thanks.

@PatrickJS PatrickJS deleted the patch-1 branch June 11, 2015 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatrickJS @coveralls @stevemao