Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problematic semicolon in CSS media queries #4849

Merged
merged 2 commits into from
Aug 25, 2022

Conversation

anijanyan
Copy link
Contributor

Issue #, if available: #4126

Description of changes: Autocomplete in css mode is no more adding semicolon if used within parentheses

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #4849 (27ccd26) into master (d5842cb) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #4849      +/-   ##
==========================================
- Coverage   85.76%   85.75%   -0.02%     
==========================================
  Files         539      539              
  Lines       40723    40728       +5     
  Branches     6442     6445       +3     
==========================================
  Hits        34928    34928              
- Misses       5795     5800       +5     
Flag Coverage Δ
unittests 85.75% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/css_completions.js 20.00% <14.28%> (-2.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@anijanyan anijanyan marked this pull request as ready for review July 25, 2022 13:02
@andrewnester
Copy link
Contributor

@anijanyan thanks! the change looks good, but there are some merge conflicts. Could you please resolve them so we can safely merge the PR?

@anijanyan
Copy link
Contributor Author

@andrewnester thanks! Merge conflicts are resolved now.

@andrewnester andrewnester merged commit 18a459a into ajaxorg:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants