Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable error level handling and custom loggers #20

Merged
merged 8 commits into from
May 28, 2021
Merged

Add configurable error level handling and custom loggers #20

merged 8 commits into from
May 28, 2021

Conversation

tbonfort
Copy link
Member

@tbonfort tbonfort commented May 3, 2021

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented May 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 886228831

  • 946 of 965 (98.03%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 98.395%
Changes Missing Coverage Covered Lines Changed/Added Lines %
errors.go 164 166 98.8%
godal.go 428 430 99.53%
options.go 204 219 93.15%
Files with Coverage Reduction New Missed Lines %
godal.go 1 98.85%
Totals Coverage Status
Change from base Build 879313267: 0.1%
Covered Lines: 2329
Relevant Lines: 2367
💛 - Coveralls

@tbonfort tbonfort mentioned this pull request May 3, 2021
Closed
@tbonfort tbonfort marked this pull request as draft May 3, 2021 17:10
@tbonfort tbonfort force-pushed the error-and-log-levels branch from aea23d9 to a0f4ab0 Compare May 28, 2021 08:34
@tbonfort tbonfort marked this pull request as ready for review May 28, 2021 16:24
@tbonfort tbonfort merged commit 16c85fb into main May 28, 2021
@tbonfort tbonfort deleted the error-and-log-levels branch May 28, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbonfort @coveralls