Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uuid 2.x -> 3.x #998

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Update uuid 2.x -> 3.x #998

merged 1 commit into from
Jun 22, 2017

Conversation

lencioni
Copy link
Contributor

@airbnb/webinfra

@ljharb ljharb merged commit d34630e into master Jun 22, 2017
@ljharb ljharb deleted the uuid branch June 22, 2017 07:32
@tstirrat15
Copy link

@ljharb this has the potential to result in a broken build of enzyme.

The 3.0.0 version of uuid doesn't support the uuid/v4 import style, and will throw an error on import. I ran into this problem in my own project. 3.1.0 doesn't experience this problem.

I'm not sure how npm determines which version of a package to pull when resolving dependencies beyond the first layer - this may be to blame?

@lencioni
Copy link
Contributor Author

lencioni commented Jun 22, 2017

Ah my bad. It looks like that was added in 3.0.1. I'll open a PR to fix.

Update: PR is here: #1001

lencioni added a commit that referenced this pull request Jun 22, 2017
In #998 I bumped uuid 2.x -> 3.x and converted the import to
import from `uuid/v4`, but this didn't exist until 3.0.1.
@ljharb
Copy link
Member

ljharb commented Jun 22, 2017

Thanks - it would only result in 3.0.0 if something else in the dep graph pinned to that version, but it's a good idea to fix it asap :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants