Fix #925 - indentation is broken for debug() on shallow wrapper #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ljharb Thanks for looking. I pushed an additional commit to skip these new tests on v0.13 where they were failing. |
ljharb
requested changes
May 3, 2017
test/Debug-spec.jsx
Outdated
| }); | ||
| }); | ||
|
|
||
| describeIf(!REACT013, 'debugNodes', () => { |
There was a problem hiding this comment.
instead of skipping these tests on react 13, can we just not use an SFC?
There was a problem hiding this comment.
Ah, got it. Good idea, I can try that.
|
@ljharb updated |
ljharb
previously approved these changes
May 3, 2017
nfcampos
previously approved these changes
May 6, 2017
|
@finnigantime please don't use the update branch button in Github's UI - this needs a rebase on the command line. |
finnigantime
force-pushed
the
finnigantime/shallowPrintTree
branch
from
2f57e62 to
dc34bc3
Compare
finnigantime
force-pushed
the
finnigantime/shallowPrintTree
branch
2 times, most recently
from
b24424f to
21a5ebf
Compare
|
Should be squashed and rebased against the latest master commit now. |
|
The tests are failing due to npm v4.6 breaking on node < 1.0. I'll fix in master, after which you can rebase. |
|
@finnigantime k, if you rebase once more it should pass |
finnigantime
force-pushed
the
finnigantime/shallowPrintTree
branch
from
21a5ebf to
f72cae6
Compare
|
@ljharb Thanks! Green build. G2G? |
ljharb
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
DETAILS
The problem is with the use of
.map():Array.map passes 3 args to the callback, the second of which is the current index (0 in this case since there's only one top-level node), which overrides the default arg value
indentLength = 2in debugNode.The fix here adds a callback that explicitly only takes one parameter and then calls debugNode explicitly with that single parameter:
nodes.map(node => debugNode(node))