Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw for malformed compound selectors #868

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Throw for malformed compound selectors #868

merged 1 commit into from
Apr 1, 2017

Conversation

nfcampos
Copy link
Collaborator

@nfcampos nfcampos commented Apr 1, 2017

closes #794

interim solution until we switch to a proper CSS selector solution

@nfcampos nfcampos requested review from ljharb and blainekasten April 1, 2017 17:56
ljharb
ljharb approved these changes Apr 1, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@nfcampos nfcampos merged commit 7cd2e9a into master Apr 1, 2017
@nfcampos nfcampos deleted the fix/794 branch April 1, 2017 19:32
@nfcampos nfcampos removed the request for review from blainekasten April 1, 2017 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unbalanced HTML attribute name selector results in "RangeError: Maximum call stack size exceeded"
2 participants
@nfcampos @ljharb