Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] mount: ensure that react-text comment nodes don’t break .find #691

Merged
merged 1 commit into from
Nov 19, 2016
Merged

[Fix] mount: ensure that react-text comment nodes don’t break .find #691

merged 1 commit into from
Nov 19, 2016

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Nov 17, 2016

Fixes #689.

  • add shallow test just in case
  • use values over Object.keys in MountedTraversal

@ljharb
[Fix] mount: ensure that react-text comment nodes don’t break `.f…
8db9f23 
…ind`

 - add `shallow` test just in case
 - use `values` over `Object.keys` in MountedTraversal

Fixes enzymejs#689.
@ljharb ljharb force-pushed the fix_mount_comments branch from d4f9e76 to 560e726 Compare November 18, 2016 07:17
@ljharb ljharb mentioned this pull request Nov 18, 2016
Closed
@ljharb ljharb force-pushed the fix_mount_comments branch from 560e726 to 8db9f23 Compare November 19, 2016 04:41
@ljharb ljharb merged commit 8db9f23 into enzymejs:master Nov 19, 2016
@ljharb ljharb deleted the fix_mount_comments branch November 19, 2016 05:49
@ljharb ljharb mentioned this pull request Feb 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lelandrichardson lelandrichardson lelandrichardson approved these changes

Assignees
No one assigned
Labels
API: mount semver: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljharb @lelandrichardson