Support for Stateless Components #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| getWrappedComponent() { | ||
| const component = this._reactInternalInstance._renderedComponent; | ||
| const inst = component.getPublicInstance(); | ||
| if (inst === null) { |
There was a problem hiding this comment.
Is there any case where inst is falsy but not null? if not, you could return component.getPublicInstance() || component? nbd
There was a problem hiding this comment.
AFAICT its always null
|
LGTM - this seems like a minor bump? |
lelandrichardson
added a commit
that referenced
this pull request
Dec 6, 2015
Support for Stateless Components
lelandrichardson
added a commit
that referenced
this pull request
Dec 7, 2015
This was referenced Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ljharb @goatslacker
Adds support for stateless functional components.
Brought up in #45
Functional components cannot be a ref, and thus the "wrapper component" did not work with them.
Note that functional components are only available in react 0.14, so the tests for them are only run for react 0.14...