[Fix] {ShallowWrapper,ReactWrapper}#{type,props}() should work with null nodes
#162
Conversation
…er#props()` should work with `null` nodes. Fixes #113.
| return this.single(n => getNode(n).props || {}); | ||
| return this.single((n) => { | ||
| const node = getNode(n); | ||
| return node ? node.props || {} : {}; |
There was a problem hiding this comment.
i think in the Utils file there is a propsOfNode function that we should probably be using instead of this. It deals with things like null being passed in.
There was a problem hiding this comment.
Sounds good - will that work the same in shallow and mount?
ljharb
force-pushed
the
shallow_fix_nulls_in_sfcs
branch
from
c7d0670 to
198db6c
Compare
[Fix] `{ShallowWrapper,ReactWrapper}#{type,props}()` should work with `null` nodes
|
@ljharb I'm wondering -- why would we want wrappers with null nodes to get passed to |
|
That's a good point, and may be an alternative approach. |
|
Yeah I was going to post an issue about |
|
Let's do that - findWhere and filterWhere etc perhaps shouldn't return |
|
Okay, sounds good |
|
And thanks for this awesome project! |
Fixes #113.
^ @lelandrichardson, @goatslacker