[Fix] mount: do not mutate Component.contextTypes
#1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweary
approved these changes
Aug 30, 2017
| describe('does not attempt to mutate Component.childContextTypes', () => { | ||
| const SimpleComponent = createClass({ | ||
| displayName: 'Simple', | ||
| // contextTypes: Object.freeze({ b: PropTypes.string }), |
There was a problem hiding this comment.
Should this be deleted or uncommented?
ljharb
force-pushed
the
fix_mount_contexttypes
branch
from
67e9397 to
10ee064
Compare
|
(this bug originated in #171) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091.
Turns out that this was only an issue on class-based components (possibly SFCs as well), presumably because createClass clones
contextTypesfor us.