Remove all React dependencies from enzyme #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lelandrichardson
force-pushed
the
lmr--remove-react-components
branch
2 times, most recently
from
e63c3bb to
1364f2e
Compare
ljharb
approved these changes
Aug 21, 2017
packages/enzyme/src/ReactWrapper.js
Outdated
| @@ -117,7 +99,7 @@ class ReactWrapper { | |||
| privateSet(this, NODES, nodes); | |||
| } | |||
| this.length = this[NODES].length; | |||
| privateSet(this, COMPONENT, null); | |||
| // privateSet(this, COMPONENT, null); | |||
lelandrichardson
force-pushed
the
lmr--remove-react-components
branch
from
1364f2e to
76951a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ljharb @aweary
This PR removes all react dependencies from the core enzyme library. In order to do this, the component "wrappers" were moved from enzyme into the adapters. This ends up cleaning up a number of things, and I think worked out rather nicely.