Remove isFunctionalComponent, use nodeType instead #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aweary
commented
Aug 17, 2017
| @@ -346,7 +345,7 @@ class ShallowWrapper { | |||
| if (this.root !== this) { | |||
| throw new Error('ShallowWrapper::setState() can only be called on the root'); | |||
| } | |||
| if (this.instance() === null || isFunctionalComponent(this.instance())) { | |||
| if (this.instance() === null || this.renderer.getNode().nodeType === 'function') { | |||
There was a problem hiding this comment.
We have agetNodeInternal helper but it returns the rendered node, and here we need the actual root node.
lelandrichardson
approved these changes
Aug 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes usage of
isFunctionalComponentwhich caused some problems when running tests with the production React bundles (see find(MyStatelessFunctionalComponent) fails when running on minified react-dom #1041)Fixes an issue where the shallow renderers were returning an incorrect
nodeTypefor the root node. It was always returning'class'even when the component was functional.