Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for SA #93

Merged
merged 16 commits into from
Jun 15, 2023
Merged

add tests for SA #93

merged 16 commits into from
Jun 15, 2023

Conversation

maypink
Copy link
Collaborator

@maypink maypink commented May 3, 2023

Integration test for SA and test for preprocessing were added.

@maypink maypink linked an issue May 3, 2023 that may be closed by this pull request
@aim-pep8-bot
Copy link
Collaborator

aim-pep8-bot commented May 3, 2023

Hello @maypink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-06-15 08:02:18 UTC

@maypink maypink requested a review from gkirgizov June 14, 2023 11:13
@maypink maypink added the test Adding or fixing tests label Jun 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #93 (069c7a7) into main (3dc2a9b) will increase coverage by 0.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   71.30%   72.02%   +0.71%     
==========================================
  Files         120      127       +7     
  Lines        6691     7284     +593     
==========================================
+ Hits         4771     5246     +475     
- Misses       1920     2038     +118     

see 33 files with indirect coverage changes

@maypink maypink force-pushed the 92-add-tests-for-sa branch from 069c7a7 to 745a4e3 Compare June 15, 2023 08:02
@maypink maypink merged commit d096fc8 into main Jun 15, 2023
@maypink maypink deleted the 92-add-tests-for-sa branch June 15, 2023 08:11
YamLyubov pushed a commit that referenced this pull request Jun 15, 2023
* fix

* fix#2

* minor

* add integrational test

* update tests

* fix pep8
YamLyubov pushed a commit that referenced this pull request Jun 15, 2023
* fix

* fix#2

* minor

* add integrational test

* update tests

* fix pep8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding or fixing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for SA
4 participants