crossover for multi root graphs #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_drop_mutation-fails-to-remove-node
|
Hello @maypink! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-04-21 08:41:14 UTC |
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 72.07% 71.33% -0.75%
==========================================
Files 115 115
Lines 6310 6453 +143
==========================================
+ Hits 4548 4603 +55
- Misses 1762 1850 +88
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gkirgizov
requested changes
Apr 19, 2023
gkirgizov
approved these changes
Apr 20, 2023
maypink
force-pushed
the
63-implement-crossover-for-graphs-with-multiple-roots
branch
from
b8fdbe9 to
86ff2cd
Compare
maypink
deleted the
63-implement-crossover-for-graphs-with-multiple-roots
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
equivalent_subtreewas considering only common subgraphs on the same level of graph (e.g. root_node has 0 level and all primary nodes have maximum level). Also the list of common subgraphs wasn't comprehensive.Now it returns the list of all common subgraphs. However, since we are considdering all primary nodes, the full list of common subgraphs can be large, therefore
with_primary_nodeswas added.equivalent_subtreefor graphs with multi roots fixed itself somehow with fixing single root case.