Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutation fixes: separate specific mutations from operator #55

Merged
merged 14 commits into from
Mar 6, 2023
Merged

Mutation fixes: separate specific mutations from operator #55

merged 14 commits into from
Mar 6, 2023

Conversation

gkirgizov
Copy link
Collaborator

@gkirgizov gkirgizov commented Mar 2, 2023 •
edited
Loading

  • Now Mutation operator is agnostic of specific mutations that are used by it
  • Default mutations are in a separate file base_mutations
  • Several fixes for mutations, mostly related to cyclic graphs

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #55 (e84ea7c) into main (ad4eac4) will increase coverage by 0.11%.
The diff coverage is 91.28%.

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   73.54%   73.65%   +0.11%     
==========================================
  Files          97       98       +1     
  Lines        5330     5345      +15     
==========================================
+ Hits         3920     3937      +17     
+ Misses       1410     1408       -2
Impacted Files Coverage Δ
golem/core/dag/verification_rules.py 97.56% <50.00%> (-2.44%) ⬇️
golem/core/dag/linked_graph_node.py 97.67% <85.71%> (+2.21%) ⬆️
golem/core/optimisers/genetic/gp_optimizer.py 97.64% <87.50%> (+1.99%) ⬆️
...ore/optimisers/genetic/operators/base_mutations.py 90.10% <90.10%> (ø)
golem/core/dag/graph_utils.py 94.73% <100.00%> (ø)
golem/core/dag/linked_graph.py 100.00% <100.00%> (ø)
golem/core/optimisers/genetic/gp_params.py 100.00% <100.00%> (ø)
...olem/core/optimisers/genetic/operators/mutation.py 95.45% <100.00%> (+4.70%) ⬆️
...lem/serializers/coders/graph_node_serialization.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gkirgizov gkirgizov changed the title Separate specific mutations from Mutation operator Mutation fixes: separate specific mutations from operator Mar 2, 2023
@YamLyubov YamLyubov self-requested a review March 2, 2023 10:05
@gkirgizov gkirgizov mentioned this pull request Mar 3, 2023
Open
YamLyubov
YamLyubov reviewed Mar 3, 2023
View reviewed changes
golem/core/dag/linked_graph_node.py Outdated Show resolved Hide resolved
golem/core/dag/graph_utils.py Outdated Show resolved Hide resolved
@gkirgizov gkirgizov requested review from YamLyubov and nicl-nno March 3, 2023 12:38
@gkirgizov gkirgizov merged commit 576f578 into main Mar 6, 2023
@gkirgizov gkirgizov deleted the mutations-simplify branch March 6, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLisbon ChrisLisbon ChrisLisbon approved these changes

@YamLyubov YamLyubov YamLyubov approved these changes

@nicl-nno nicl-nno nicl-nno approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gkirgizov @codecov-commenter @nicl-nno @YamLyubov @ChrisLisbon