Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conflict netcomp #17

Merged
merged 4 commits into from
Dec 26, 2022
Merged

Fix conflict netcomp #17

merged 4 commits into from
Dec 26, 2022

Conversation

YamLyubov
Copy link
Collaborator

  • Modules from NetComp are copied to GOLEM (netcomp_components). NetComp license is placed in the same directory
  • Graph metrics are moved to a separate directory (metrics)
  • examples.txt is removed
  • The PR to NetComp was made, but there is no answer yet (networkx 2 compatibility peterewills/NetComp#3)

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022 •
edited
Loading

Codecov Report

Merging #17 (f6c7be2) into main (147b896) will decrease coverage by 2.43%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   75.81%   73.37%   -2.44%     
==========================================
  Files          87       90       +3     
  Lines        4660     4819     +159     
==========================================
+ Hits         3533     3536       +3     
- Misses       1127     1283     +156
Impacted Files Coverage Δ
golem/metrics/graph_features.py 0.00% <0.00%> (ø)
golem/metrics/graph_metrics.py 0.00% <0.00%> (ø)
golem/metrics/mmd.py 0.00% <ø> (ø)
...olem/core/optimisers/genetic/operators/mutation.py 90.74% <0.00%> (+0.44%) ⬆️
golem/core/dag/linked_graph.py 100.00% <0.00%> (+1.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YamLyubov YamLyubov requested a review from gkirgizov December 26, 2022 07:20
gkirgizov
gkirgizov requested changes Dec 26, 2022
View reviewed changes
netcomp_components/LICENSE Outdated Show resolved Hide resolved
@YamLyubov YamLyubov force-pushed the fix-conflict-netcomp branch from 22b25f1 to f6c7be2 Compare December 26, 2022 09:40
@YamLyubov YamLyubov requested a review from gkirgizov December 26, 2022 09:42
@gkirgizov gkirgizov merged commit 55063b2 into main Dec 26, 2022
@gkirgizov gkirgizov deleted the fix-conflict-netcomp branch December 26, 2022 10:08
@gkirgizov gkirgizov linked an issue Dec 26, 2022 that may be closed by this pull request
Fix dependency conflict from netcomp package #7
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkirgizov gkirgizov gkirgizov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dependency conflict from netcomp package
3 participants
@YamLyubov @codecov-commenter @gkirgizov