Fix molecule integration test #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
==========================================
- Coverage 73.81% 73.61% -0.21%
==========================================
Files 129 129
Lines 7563 7566 +3
==========================================
- Hits 5583 5570 -13
- Misses 1980 1996 +16
|
gkirgizov
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was with
get_structure_unique_population. It was extending population using mutation (EvoGraphOptimizer._extend_population) but added molecules were not evaluated. That is why individuals with null fitness appeared in the population.#144
Also the check
optimized_network.depth > 1fromtest_customwas removed because it can find cycled graphs withdepth == -1