Add integration test and runner #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires fix for #7 |
gkirgizov
force-pushed
the
add-integration-test
branch
from
73f59d5 to
4ef0fa5
Compare
Codecov Report
@@ Coverage Diff @@
## main #14 +/- ##
==========================================
+ Coverage 73.37% 74.15% +0.77%
==========================================
Files 90 90
Lines 4819 4817 -2
==========================================
+ Hits 3536 3572 +36
+ Misses 1283 1245 -38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
YamLyubov
requested changes
Dec 27, 2022
| pareto_front_metrics = get_mean_metrics(pareto_front) | ||
|
|
||
| quality_improved = pareto_front_metrics[0] < first_pop_metrics[0] | ||
| complexity_improved = pareto_front_metrics[-1] < first_pop_metrics[1] |
There was a problem hiding this comment.
Здесь first_pop_metrics[1] скорее всего имелось в виду first_pop_metrics[-1], иначе тест падает
There was a problem hiding this comment.
для двух значений они совпадают. но поправлю. а ты можешь воспроизвести? у меня не падает
There was a problem hiding this comment.
я пока залью, для отчетности. если смодешь воспроизвести -- поправлю
gkirgizov
force-pushed
the
add-integration-test
branch
from
0d33d9d to
995272a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.