Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notification after integration tests & fix the workflow badge #130

Merged
merged 4 commits into from
Jun 20, 2023
Merged

Add notification after integration tests & fix the workflow badge #130

merged 4 commits into from
Jun 20, 2023

Conversation

MorrisNein
Copy link
Collaborator

@MorrisNein MorrisNein commented Jun 19, 2023 •
edited
Loading

  • Added telegram notification if scheduled integration tests fail
  • Renamed PR-related notification workflow
  • Added small improvements to the notification messages (the repo name, links embedded in text, etc.)
  • Fixed badge link in README.rst and README_en.rst

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023 •
edited
Loading

Codecov Report

Merging #130 (496462e) into main (acf3e5d) will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   72.04%   72.39%   +0.35%     
==========================================
  Files         127      128       +1     
  Lines        7289     7336      +47     
==========================================
+ Hits         5251     5311      +60     
+ Misses       2038     2025      -13

see 11 files with indirect coverage changes

@MorrisNein MorrisNein force-pushed the integration_tests_notification branch 5 times, most recently from 4079444 to 076a5c5 Compare June 19, 2023 17:56
@MorrisNein MorrisNein force-pushed the integration_tests_notification branch from b1439c6 to 8686635 Compare June 19, 2023 18:17
@MorrisNein MorrisNein requested a review from gkirgizov June 19, 2023 18:23
@gkirgizov
Copy link
Collaborator

О, класс. А можешь еще посмотреть, что не так с бэйджем?
image

gkirgizov
gkirgizov reviewed Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@gkirgizov gkirgizov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо сказать, что сейчас нотификации в ТГ не приходят. Что-то вроде Auth error
#116

Если есть идея, что не так мб с токеном -- буду благодарен.

UPD Увидел, что заработало. Что бы ты не сделал -- спасибо )

@gkirgizov gkirgizov linked an issue Jun 20, 2023 that may be closed by this pull request
Fix telegram_notify error #116
Closed
@MorrisNein
Copy link
Collaborator Author

Надо сказать, что сейчас нотификации в ТГ не приходят. Что-то вроде Auth error
#116

Если есть идея, что не так мб с токеном -- буду благодарен.

UPD Увидел, что заработало. Что бы ты не сделал -- спасибо )

Перепроверили токен с Колей, действительно был неправильный.

@MorrisNein
Copy link
Collaborator Author

MorrisNein commented Jun 20, 2023 •
edited
Loading

О, класс. А можешь еще посмотреть, что не так с бэйджем? image

@gkirgizov, пофиксил

https://github.com/aimclub/GOLEM/tree/integration_tests_notification#readme

@MorrisNein MorrisNein changed the title Add notification after integration tests Add notification after integration tests & fix badge Jun 20, 2023
@MorrisNein MorrisNein changed the title Add notification after integration tests & fix badge Add notification after integration tests & fix the workflow badge Jun 20, 2023
@MorrisNein MorrisNein merged commit 522878e into main Jun 20, 2023
@MorrisNein MorrisNein deleted the integration_tests_notification branch June 20, 2023 11:03
MorrisNein added a commit to aimclub/FEDOT that referenced this pull request Jun 20, 2023
@MorrisNein
pull changes from aimclub/GOLEM#130
5fd4df4
@MorrisNein MorrisNein mentioned this pull request Jun 20, 2023
Merged
@MorrisNein MorrisNein restored the integration_tests_notification branch June 20, 2023 12:58
MorrisNein added a commit that referenced this pull request Jun 20, 2023
@MorrisNein
Revert "Add notification after integration tests & fix the workflow b…
bdfa512 
…adge (#130)"

This reverts commit 522878e.
@MorrisNein MorrisNein deleted the integration_tests_notification branch June 20, 2023 13:07
MorrisNein added a commit that referenced this pull request Jun 20, 2023
@MorrisNein
Hotfix #130 (#132)
5c9e419
MorrisNein added a commit to aimclub/FEDOT that referenced this pull request Aug 17, 2023
@MorrisNein
Add notification after failed integration tests (#1111)
3d2809b 
Pull changes from aimclub/GOLEM#130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkirgizov gkirgizov gkirgizov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix telegram_notify error
3 participants
@MorrisNein @codecov-commenter @gkirgizov