Fix metric setting in tuners #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-06-15 13:17:30 UTC |
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 72.21% 72.14% -0.07%
==========================================
Files 127 127
Lines 7284 7289 +5
==========================================
- Hits 5260 5259 -1
- Misses 2024 2030 +6
|
maypink
approved these changes
Jun 15, 2023
golem/core/tuning/iopt_tuner.py
Outdated
|
|
||
| self.was_tuned = True | ||
|
|
||
| tuned_graph = self.adapter.restore(graph) | ||
| return tuned_graph | ||
| # Validation is the optimization do well |
There was a problem hiding this comment.
имелось ввиду -- валидировать, если оптимизация прошла успешно?
There was a problem hiding this comment.
Да, скорее лучше написать: Validate if optimisation did well
YamLyubov
added a commit
that referenced
this pull request
Jun 15, 2023
* Fix metric setting * PEP 8 * Correct comments
YamLyubov
added a commit
that referenced
this pull request
Jun 15, 2023
* Fix metric setting * PEP 8 * Correct comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously setting of
self.obtained_metricwas incorrect which was leading to integration test failing in FEDOT