-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom operator serialize #120
Conversation
Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-06-28 10:40:04 UTC |
46157cc
to
5497a1f
Compare
test/unit/serialization/dataclasses_serialisation/serialization_dataclasses.py
Outdated
Show resolved
Hide resolved
Сделаешь PR туда с этим микрофиксом? |
21a102d
to
80acc48
Compare
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 73.19% 73.28% +0.09%
==========================================
Files 128 128
Lines 7337 7364 +27
==========================================
+ Hits 5370 5397 +27
Misses 1967 1967
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
С одной стороны, удобно, а с другой, я не понял, какую проблему это устраняет
Вообще, как будто это эффективно прячет из вида проблемы обратной совместимости истории
По реализации небольшой вопрос + правка по стилю, в остальном всё норм
В общем, @YamLyubov, напиши кратко, как это используется, в описание PR, пожалуйста! Либо ссылку на issue, если такая есть |
440ac76
to
b2b2097
Compare
cd58abd
to
bee4e46
Compare
Now when Serializer is not able to import some modules during decoding, firstly, it tries to decode it as a LinkedGraph or as a LinkedGraphNode. If it fails, such objects are just stored as a dict.
Solves #109
Most of the visualizations work for such not fully decoded histories.
Gifs are not very informative because of the task specifics.
Also I tested these solution with local FEDOT.Web. In general it works
This visualization works with one line correction in FEDOT.Web code