Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom operator serialize #120

Merged
merged 18 commits into from
Jun 28, 2023
Merged

Custom operator serialize #120

merged 18 commits into from
Jun 28, 2023

Conversation

YamLyubov
Copy link
Collaborator

@YamLyubov YamLyubov commented Jun 13, 2023

Now when Serializer is not able to import some modules during decoding, firstly, it tries to decode it as a LinkedGraph or as a LinkedGraphNode. If it fails, such objects are just stored as a dict.

Solves #109

Most of the visualizations work for such not fully decoded histories.
Gifs are not very informative because of the task specifics.

image image
operations_animated_bar operations_kde

Also I tested these solution with local FEDOT.Web. In general it works
image
image

image image

This visualization works with one line correction in FEDOT.Web code

image

@aim-pep8-bot
Copy link
Collaborator

aim-pep8-bot commented Jun 13, 2023

Hello @YamLyubov! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-06-28 10:40:04 UTC

@YamLyubov YamLyubov force-pushed the custom-operator-serialize branch 2 times, most recently from 46157cc to 5497a1f Compare June 16, 2023 13:48
@gkirgizov
Copy link
Collaborator

This visualization works with one line correction in FEDOT.Web code

Сделаешь PR туда с этим микрофиксом?

@YamLyubov YamLyubov force-pushed the custom-operator-serialize branch from 21a102d to 80acc48 Compare June 20, 2023 12:01
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #120 (61262c8) into main (b729682) will increase coverage by 0.09%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   73.19%   73.28%   +0.09%     
==========================================
  Files         128      128              
  Lines        7337     7364      +27     
==========================================
+ Hits         5370     5397      +27     
  Misses       1967     1967              
Impacted Files Coverage Δ
golem/serializers/coders/graph_serialization.py 96.00% <91.66%> (-4.00%) ⬇️
golem/serializers/serializer.py 95.40% <95.83%> (+1.24%) ⬆️
golem/core/optimisers/genetic/gp_optimizer.py 98.78% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

@YamLyubov YamLyubov requested a review from gkirgizov June 20, 2023 12:58
@gkirgizov gkirgizov requested a review from MorrisNein June 21, 2023 08:45
Copy link
Collaborator

@MorrisNein MorrisNein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С одной стороны, удобно, а с другой, я не понял, какую проблему это устраняет

Вообще, как будто это эффективно прячет из вида проблемы обратной совместимости истории

По реализации небольшой вопрос + правка по стилю, в остальном всё норм

golem/serializers/coders/graph_serialization.py Outdated Show resolved Hide resolved
golem/serializers/serializer.py Outdated Show resolved Hide resolved
golem/serializers/serializer.py Outdated Show resolved Hide resolved
@MorrisNein
Copy link
Collaborator

В общем, @YamLyubov, напиши кратко, как это используется, в описание PR, пожалуйста! Либо ссылку на issue, если такая есть

@gkirgizov gkirgizov linked an issue Jun 22, 2023 that may be closed by this pull request
@YamLyubov YamLyubov force-pushed the custom-operator-serialize branch from 440ac76 to b2b2097 Compare June 23, 2023 12:45
@YamLyubov YamLyubov requested a review from MorrisNein June 26, 2023 10:48
golem/serializers/serializer.py Outdated Show resolved Hide resolved
golem/serializers/serializer.py Outdated Show resolved Hide resolved
@YamLyubov YamLyubov force-pushed the custom-operator-serialize branch from cd58abd to bee4e46 Compare June 27, 2023 08:49
@YamLyubov YamLyubov requested a review from MorrisNein June 27, 2023 08:51
golem/serializers/serializer.py Outdated Show resolved Hide resolved
@YamLyubov YamLyubov merged commit 52efb68 into main Jun 28, 2023
@YamLyubov YamLyubov deleted the custom-operator-serialize branch June 28, 2023 10:50
@YamLyubov YamLyubov restored the custom-operator-serialize branch October 2, 2023 13:23
@maypink maypink deleted the custom-operator-serialize branch October 27, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialize: Add support fon non-implemented custom operators
5 participants