Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes in OptHistory #108

Merged
merged 4 commits into from
May 31, 2023
Merged

Minor fixes in OptHistory #108

merged 4 commits into from
May 31, 2023

Conversation

MorrisNein
Copy link
Collaborator

  • Turned logger into property, since logger is not serialized and thus not recreated during deseralization.
  • Renamed OptHistory.individuals -> generations, added deprecation warning for the older variant.

@aim-pep8-bot
Copy link
Collaborator

aim-pep8-bot commented May 26, 2023 •
edited
Loading

Hello @MorrisNein! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 24:5: F401 'PIL.Image' imported but unused
Line 133:9: F811 redefinition of unused 'Image' from line 24
Line 201:36: F541 f-string is missing placeholders

Comment last updated at 2023-05-31 17:13:08 UTC

@MorrisNein MorrisNein force-pushed the history_minor_fix branch from f67e5fc to a6a25cf Compare May 26, 2023 13:47
@MorrisNein MorrisNein force-pushed the history_minor_fix branch from a57f713 to bac1727 Compare May 31, 2023 17:12
@codecov-commenter
Copy link

Codecov Report

Merging #108 (bac1727) into main (4aadb7a) will increase coverage by 0.12%.
The diff coverage is 74.41%.

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   71.83%   71.96%   +0.12%     
==========================================
  Files         122      122              
  Lines        6835     6852      +17     
==========================================
+ Hits         4910     4931      +21     
+ Misses       1925     1921       -4
Impacted Files Coverage Δ
golem/visualisation/opt_viz_extra.py 21.36% <ø> (ø)
golem/visualisation/opt_history/fitness_line.py 38.82% <33.33%> (ø)
...core/optimisers/opt_history_objects/opt_history.py 70.90% <71.42%> (-0.43%) ⬇️
...em/serializers/coders/opt_history_serialization.py 98.71% <87.50%> (+0.03%) ⬆️
...isualisation/opt_history/arg_constraint_wrapper.py 90.90% <100.00%> (ø)
golem/visualisation/opt_history/fitness_box.py 90.32% <100.00%> (ø)
golem/visualisation/opt_history/operations_kde.py 80.00% <100.00%> (ø)
golem/visualisation/opt_history/utils.py 57.33% <100.00%> (ø)

... and 2 files with indirect coverage changes

@MorrisNein MorrisNein merged commit 348f596 into main May 31, 2023
@MorrisNein MorrisNein deleted the history_minor_fix branch May 31, 2023 18:49
YamLyubov pushed a commit that referenced this pull request Jun 14, 2023
@MorrisNein @YamLyubov
Minor fixes in OptHistory (#108)
99b1c64 
* Turn logger into property, since logger is not serialized and thus not recreated during deseralization.

* Rename `OptHistory.individuals` -> `generations`, add deprecation warning for the older variant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamLyubov YamLyubov YamLyubov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisNein @aim-pep8-bot @codecov-commenter @YamLyubov