Preserving of optimisation results implemented #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisSidoren
requested changes
Jul 27, 2022
DenisSidoren
approved these changes
Aug 11, 2022
|
|
||
| @staticmethod | ||
| def _get_class(class_path: str) -> Type[INSTANCE_OR_CALLABLE]: | ||
| """Gets the object type from the class_path |
There was a problem hiding this comment.
этот метод скрытый, зачем его документировать докстрингами?
если им можно пользоваться, то почему он не может быть обычным?
There was a problem hiding this comment.
Документировать не обязательно, но лишним не будет. В таком виде взял из FEDOT-а.
| """Decodes every JSON-object to python class/func object or just returns dict | ||
|
|
||
| Args: | ||
| json_obj: dict[str, Any] to be decoded into Python class, function or |
There was a problem hiding this comment.
типы объектов принималось обозначать через type, то есть dict[str, Any]
в таком случае этот объект будет в симпатишном квадратике
There was a problem hiding this comment.
при этом сами объекты, например Point, Domain и прочее, вот так -> :obj:Domain
There was a problem hiding this comment.
Пока просто убрал дублирующую type hint-ы типизацию.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results of gen. dis. can be saved in JSON using Result class.