Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict the max height of ChatResponse #894

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Restrict the max height of ChatResponse #894

merged 1 commit into from
Sep 29, 2024

Conversation

cesaryuan
Copy link
Contributor

@cesaryuan cesaryuan commented Jul 22, 2024 •
edited by coderabbitai bot
Loading

There is no limit to the current response height, so when some Bots reply with little content, there will be a lot of blank space under a Bot, which is inconvenient for reading. Therefore, a maximum height limit is added.

Before:
image

After:
image

Summary by CodeRabbit

  • New Features
    • Introduced a new CSS class to enhance the styling of the Markdown editor preview, improving its height and overflow behavior for better user experience.

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 1:02pm

PeterDaveHello
PeterDaveHello reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was the maximum height determined? Should it be higher, or should users be allowed to configure it themselves?

@PeterDaveHello
Copy link
Collaborator

@coderabbitai review

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 21, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 21, 2024 •
edited
Loading

Walkthrough

The changes include the addition of a new CSS class named .v-md-editor-preview in the ChatResponse.vue file. This class sets a maximum height of 50vh and modifies the vertical overflow behavior to overlay, which affects the styling of the Markdown editor preview component.

Changes

Files Change Summary
src/components/Messages/ChatResponse.vue Added new CSS class .v-md-editor-preview to control height and overflow.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ChatResponse
    participant MarkdownEditor

    User->>ChatResponse: Render component
    ChatResponse->>MarkdownEditor: Display Markdown content
    MarkdownEditor->>ChatResponse: Return rendered preview
    ChatResponse->>User: Show preview with .v-md-editor-preview styles
Loading

Poem

In a world of text and rhyme,
A class was born, oh what a time!
With height set high, and overflow neat,
The Markdown preview is now a treat!
Hopping through code, we cheer and play,
For styling magic brightens the day! 🐇✨

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f934d5c and 594eb24.

Files selected for processing (1)
  • src/components/Messages/ChatResponse.vue (1 hunks)
Additional comments not posted (1)
src/components/Messages/ChatResponse.vue (1)

621-624: Looks good! The height restriction enhances the layout and readability.

The new CSS class .v-md-editor-preview effectively limits the maximum height of the Markdown preview to 50vh, preventing it from occupying excessive vertical space. The overflow-y: overlay property ensures that the content remains scrollable within the constrained dimensions, improving the user experience when dealing with lengthy responses.

Great work on implementing this enhancement!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cesaryuan
Copy link
Contributor Author

How was the maximum height determined? Should it be higher, or should users be allowed to configure it themselves?

The questions you raised are very constructive. I didn’t consider so much when I proposed this PR. Maybe I can add a setting in the future.

PeterDaveHello
PeterDaveHello approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try.

@PeterDaveHello PeterDaveHello merged commit 95ccdc2 into ai-shifu:main Sep 29, 2024
2 checks passed
eddieai pushed a commit to eddieai/ChatALL that referenced this pull request Nov 15, 2024
@cesaryuan
Restrict the max height of ChatResponse (ai-shifu#894)
b9fb97c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterDaveHello PeterDaveHello PeterDaveHello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cesaryuan @PeterDaveHello