-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy LLaMA2 70b via Groq Cloud API #839
Remove legacy LLaMA2 70b via Groq Cloud API #839
Conversation
Groq removed it and replaced with Llama 3 since 25 April. Reference: - https://twitter.com/GroqInc/status/1783235427916251464
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Directly remove code will break app since legacy data can't be parsed right. Could you just kindly add it to the disabled list? Someday later, we can remove it in a whole. Disabled list: https://github.com/sunner/ChatALL/blob/9b730057b80251e4be94bd91acd6067a80b9a431/src/bots/index.js#L171-L181 |
Maybe the solution is to fix the parse method? |
Do you mean fix the parse method in the chat view? If so, there are two solutions:
Solution 1 looks like data loss. Solution 2 will lead to duplicate code. IMO, disable the removed bot in the bots menu is the best solution. What do you think? |
I prefer not to keep legacy and deprecated codes or naming in the project. It'll make the maintenance complexity much higher and also make it harder for new contributors to join. That's also why I want #780. |
I understand your concern. How about moving the legacy codes to a |
Yeah, I also got your point, the legacy folder could be a workaround, though I doubt how many users will keep all those old bots conversations, considering the AI evolutions are currently so fast, most users will use the newer models, and this currently broken bots didn't cause obvious bug reports, maybe we can just remove it after a month? Anyway, I can close this PR if the workaround is something we both think is possible. |
@sunner maybe more than two months is long enough to remove it now? |
@PeterDaveHello It is good. |
Groq removed it and replaced with Llama 3 since 25 April.
Reference: