Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy GPT-3.5 Turbo 16k via OpenAI API #838

Conversation

PeterDaveHello
Copy link
Collaborator

@PeterDaveHello PeterDaveHello commented May 14, 2024

gpt-3.5-turbo now default has the 16k context window, and gpt-3.5-turbo-16k has been marked legacy, though it's not deprecated, there seems to be no reason to maintain both of them.

Reference:

Summary by CodeRabbit

  • New Features

    • New bot instances added: GeminiAdvBot, Gemma7bItBot, Gemma2bItBot, Claude3SonnetBot, Claude3OpusBot, and KimiBot to enhance user options.
  • Bug Fixes

    • Removed references to the gpt-35-turbo-16k model across multiple localization files, ensuring users only see currently supported models.
  • Documentation

    • Updated localization files to reflect the removal of the gpt-35-turbo-16k entry in English, Spanish, Japanese, Korean, Vietnamese, Chinese, and Traditional Chinese.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chatall ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 4:26pm

@PeterDaveHello
Copy link
Collaborator Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Sep 21, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

coderabbitai bot commented Sep 21, 2024

Walkthrough

The changes involve the complete removal of the OpenAIAPI3516KBot class and its references from the codebase, affecting both the bot collection and localization files. Specifically, the bot's import and instances have been eliminated from the src/bots/index.js file, and the class definition has been removed from src/bots/openai/OpenAIAPI3516KBot.js. Additionally, entries related to the gpt-35-turbo-16k model have been deleted from various localization files, including English, Spanish, Japanese, Korean, Vietnamese, and Chinese, indicating that this model is no longer supported. New bot instances have also been added to the collection.

Changes

Files Change Summary
src/bots/index.js Removed references to OpenAIAPI3516KBot, including import, instance from all array, and botTags. Added new bot instances.
src/bots/openai/OpenAIAPI3516KBot.js Completely removed the OpenAIAPI3516KBot class definition.
src/i18n/locales/en.json Removed entry for "gpt-35-turbo-16k".
src/i18n/locales/es.json Removed entry for "gpt-35-turbo-16k".
src/i18n/locales/ja.json Removed entry for "gpt-35-turbo-16k".
src/i18n/locales/ko.json Removed entry for "gpt-35-turbo-16k".
src/i18n/locales/vi.json Removed entry for "gpt-35-turbo-16k".
src/i18n/locales/zh.json Removed entry for "gpt-35-turbo-16k".
src/i18n/locales/zhtw.json Removed entry for "gpt-35-turbo-16k" and added new AI model names and descriptions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BotManager
    participant Localization

    User->>BotManager: Request available bots
    BotManager-->>User: Return list of bots (without OpenAIAPI3516KBot)

    User->>Localization: Request available models
    Localization-->>User: Return list of models (without gpt-35-turbo-16k)
Loading

Possibly related PRs

  • Add Gemma2 9b bot via Groq Cloud API #882: The main PR involves the addition of several new bot instances, including Gemma2bItBot, which is related to the addition of Gemma29bGroqAPIBot in the retrieved PR, indicating a connection in the bot management system.
  • Add OpenAI API gpt-4o-mini Bot #893: The main PR's changes to the src/bots/index.js file for managing bot instances relate to the addition of OpenAIAPI4oMiniBot in the retrieved PR, as both involve modifications to the same file for integrating new bot instances.

Poem

🐇 In a meadow bright and fair,
The bots have danced without a care.
The gpt-35 has hopped away,
Leaving room for new to play.
With every change, we cheer and sing,
For fresh ideas that spring and spring! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 674997d and 48890bc.

⛔ Files ignored due to path filters (1)
  • public/bots/openai-35-16k-logo.png is excluded by !**/*.png
📒 Files selected for processing (13)
  • src/bots/index.js (0 hunks)
  • src/bots/openai/OpenAIAPI3516KBot.js (0 hunks)
  • src/i18n/locales/de.json (0 hunks)
  • src/i18n/locales/en.json (0 hunks)
  • src/i18n/locales/es.json (0 hunks)
  • src/i18n/locales/fr.json (0 hunks)
  • src/i18n/locales/it.json (0 hunks)
  • src/i18n/locales/ja.json (0 hunks)
  • src/i18n/locales/ko.json (0 hunks)
  • src/i18n/locales/ru.json (0 hunks)
  • src/i18n/locales/vi.json (0 hunks)
  • src/i18n/locales/zh.json (0 hunks)
  • src/i18n/locales/zhtw.json (0 hunks)
💤 Files with no reviewable changes (13)
  • src/bots/index.js
  • src/bots/openai/OpenAIAPI3516KBot.js
  • src/i18n/locales/de.json
  • src/i18n/locales/en.json
  • src/i18n/locales/es.json
  • src/i18n/locales/fr.json
  • src/i18n/locales/it.json
  • src/i18n/locales/ja.json
  • src/i18n/locales/ko.json
  • src/i18n/locales/ru.json
  • src/i18n/locales/vi.json
  • src/i18n/locales/zh.json
  • src/i18n/locales/zhtw.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@PeterDaveHello
Copy link
Collaborator Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Sep 21, 2024

@PeterDaveHello: I have performed a full review of the PR.

Actions performed

Full review triggered.

@PeterDaveHello PeterDaveHello force-pushed the RemoveLegacy-gpt-3.5-turbo-16k branch from 674997d to 48890bc Compare October 1, 2024 22:22
@PeterDaveHello
Copy link
Collaborator Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Oct 1, 2024

@PeterDaveHello: I will review the changes.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@PeterDaveHello PeterDaveHello merged commit 69205fd into ai-shifu:main Oct 2, 2024
1 check passed
@PeterDaveHello PeterDaveHello deleted the RemoveLegacy-gpt-3.5-turbo-16k branch October 2, 2024 12:45
eddieai pushed a commit to eddieai/ChatALL that referenced this pull request Nov 15, 2024
`gpt-3.5-turbo` now default has the 16k context window, and `gpt-3.5-turbo-16k` has been marked `legacy`, though it's not `deprecated`, there seems to be no reason to maintain both of them.

Reference:
- https://platform.openai.com/docs/models/gpt-3-5-turbo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant