Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix username in README.md #66

Merged
merged 1 commit into from
Feb 26, 2017
Merged

Fix username in README.md #66

merged 1 commit into from
Feb 26, 2017

Conversation

ahmetb
Copy link
Owner

@ahmetb ahmetb commented Feb 26, 2017

No description provided.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
Copy link
Collaborator

@kalaninja kalaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to change urls in your blog posts

@kalaninja kalaninja merged commit de33bd6 into master Feb 26, 2017
@kalaninja kalaninja deleted the pr-fix-username branch February 26, 2017 18:03
@kalaninja
Copy link
Collaborator

@ahmetb fix coveralls, please

@ahmetb
Copy link
Owner Author

ahmetb commented Feb 26, 2017

I already updated those. Just to be clear, things that still will work with old repo URL:

  • go get (will actually clone repo with its old name)
  • visiting old repo URL on github (redirects)
  • git push to the old remote URL

so not many things are on fire right now. Updated readme so that new users use the right URL, plus travis badge image was broken.

@ahmetb
Copy link
Owner Author

ahmetb commented Feb 26, 2017

@kalaninja so it looks like I enabled coveralls again, however no results show up yet (maybe because there are no builds since I enabled), but goveralls upload command doesn't fail so I assume the repo token is correct. If it doesn't work I will attempt to fix it.

@ahmetb
Copy link
Owner Author

ahmetb commented Feb 26, 2017

Looks like coveralls is back, we're good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants