Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Refactor llms code using OOP, and model registry #65

Merged
merged 1 commit into from
Apr 13, 2024
Merged

[Core] Refactor llms code using OOP, and model registry #65

merged 1 commit into from
Apr 13, 2024

Conversation

lumiere-ml
Copy link
Contributor

@lumiere-ml lumiere-ml commented Apr 13, 2024 •
edited
Loading

refactor llms code using OOP, and model registry, you need to inherit baseLLM and registry model when you want to add a new model. The interface-invoke is still same as previous.which is (1) LLMKernel(args*, kwargs**) (2) llm.add_request

@lumiere-ml
refactor llms code using OOP, and model registry, you need to inherit…
410cbbf 
… baseLLM and registry model when you want to add a new model
@lumiere-ml
Copy link
Contributor Author

@dongyuanjushi please review

@dongyuanjushi dongyuanjushi merged commit e617a13 into agiresearch:dev Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongyuanjushi dongyuanjushi dongyuanjushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumiere-ml @dongyuanjushi