Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaced version #22

Merged
merged 8 commits into from
Feb 10, 2024
Merged

Namespaced version #22

merged 8 commits into from
Feb 10, 2024

Conversation

adrianbj
Copy link
Owner

No description provided.

adrianbj and others added 8 commits February 5, 2024 16:02
@adrianbj
Start to namespacing module
8a8e2a2
@adrianbj
Namespace updates
77d8b7d
@Toutouwai
Proposed changes
8a8f9ae
@adrianbj
Merge pull request #21 from Toutouwai/namespaced-version
116a94d 
Proposed changes
@adrianbj
Adjust path to FileCompiler's cached version and instantiate with glo…
b63980d 
…bal namespace as needed.

@Toutouwai - unfortunately your last version didn't work for me with actions that didn't have a PW namespace declaration, but this new version seems to reliably work either way. How's your mileage with it?

Please ignore the `$className` to `$actionName` superficial changes.
@adrianbj
Minor namespace check tweak
d8cea72
@adrianbj
Compile action file if needed.
1b4bb36
@adrianbj
Namespace all core actions and change include to includeOnce
347a770
@adrianbj adrianbj merged commit 0df90d9 into master Feb 10, 2024
@adrianbj adrianbj deleted the namespaced-version branch February 10, 2024 17:21
@adrianbj
Copy link
Owner Author

adrianbj commented Feb 10, 2024 •
edited
Loading

@Toutouwai - I have pushed that latest version (with a change to includeOnce and making all core actions namespaced) live. I did come across one issue though - I noticed that you had commented out a namespace declaration in one of your custom actions and that caused getNamespace() to still return the namespace and break the action. I have reported here (processwire/processwire-issues#1878) but you will need to modify any actions with commented namespaces until that is fixed.

@Toutouwai
Copy link
Contributor

Thanks, I noticed that too and it's no problem for me to change that at my end. I'll be wanting to add the namespace to all my custom actions anyway.

@Toutouwai
Copy link
Contributor

And a big thanks for making this update to the module!

@adrianbj
Copy link
Owner Author

And a big thanks for making this update to the module!

No worries, thanks for your help getting it dialed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianbj @Toutouwai