Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pair method doesn't ignore softDeletes #109

Closed
webdevian opened this issue Mar 10, 2017 · 8 comments
Closed

Pair method doesn't ignore softDeletes #109

webdevian opened this issue Mar 10, 2017 · 8 comments

Comments

@webdevian
Copy link
Contributor

webdevian commented Mar 10, 2017 •
edited
Loading 

yield Category.pair('id', 'name')
// or 
yield Category.query().orderBy('name', 'asc').pair('id', 'name')

Neither include a where clause for ignore soft deletes
@thetutlage
Copy link
Member

Yes, thanks for reporting. Will fix it

@webdevian
Copy link
Contributor Author

pickInverse and count also seem to miss it. I haven't tested any other methods yet.

@webdevian
Copy link
Contributor Author

ids() too

@webdevian webdevian mentioned this issue Apr 6, 2017
Closed
@webdevian
Copy link
Contributor Author

@thetutlage .query().count() still ignores soft-delete

@thetutlage
Copy link
Member

thetutlage commented Apr 12, 2017 •
edited
Loading

You have to call query().count().fetch()

@webdevian
Copy link
Contributor Author

Ok cool, will this apply to any of the Database methods?

@thetutlage
Copy link
Member

Yes, apart from few methods like first, pair etc. The docs will have the right syntax, if not I am happy to fix the docs

@webdevian
Copy link
Contributor Author

OK great thanks, now I know first thing to try next time I'm seeing deleted records.

thetutlage added a commit that referenced this issue Jul 16, 2017
@thetutlage
fix(soft-deletes): pairs and ids ignore soft deleted
0530d59 
Closes #109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thetutlage @webdevian