-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript 5.5.0 upgrade #6370
Typescript 5.5.0 upgrade #6370
Conversation
@@ -3,7 +3,7 @@ | |||
// we can explicitly declare `any`, but we don't want to infer `any` | |||
"noImplicitAny": false, | |||
// maybe bump to 'esNext'? | |||
"target": "es6", | |||
"target": "es2018", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how big a breaking change is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And perhaps more importantly, why it's needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a possible suggestion from #6366 (comment)
not sure the least breaking change way to go about this one, but also still have nice syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, in this case, it sounds like we were already "targetting" ES2018, only unknowingly :D Then I suppose it's not going to be a huge deal, still, worth a place in the release notes for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth noting that Parcel doesn't really honour the tsconfig target anyway in its transpilation, it just aims for compatibility with the set of browsers resolved by browserslist.
Since none of the versions on that list is older than 2019, this seems like it should have zero repercussions.
c7fd13a
# Conflicts: # package.json # yarn.lock
## API Changes
unknown top level export { type: 'any' } |
Closes #6366
Libraries to keep an eye on
benjamn/ast-types#948 - mildly concerned no activity in this repo for 8+ months, PR created benjamn/ast-types#950, because they haven't merged anything in 2+ years, I've taken the liberty of patch-packaging it, which required me to dedupe our copies of it
motiondivision/motion#2592 - which is resolved, so updated that here
Remaining work, use stable 5.5 release when it comes out.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: