Fix intermittent focus ring compilation issue in docs #6279
Conversation
devongovett
changed the title
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'any' } |
{{ message }}
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
changed the title
snowystinger
approved these changes
Apr 27, 2024
reidbarber
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an intermittent issue where focus rings appeared on mouse interaction. This seemed to appear on some PR builds and not others, and resulted in
:focus-visibleand:hoverpseudo classes not being compiled to the.focus-ringand.is-hoveredclasses that we apply. The native:focus-visiblepseudo class also applies on programmatic focus, which is why we see the issue.The problem was caused by a patch we had applied to skip this compilation on the React Aria tailwind-based homepage. Since all files load this config from the same package.json file, mutating it caused unintentional changes when compiling files other than the one we were looking for. It appeared intermittent because files are compiled in a different order on each build. The fix is to clone the config and modify that instead.