Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search element #39

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Search element #39

merged 4 commits into from
Oct 31, 2023

Conversation

andresin87
Copy link
Member

@andresin87 andresin87 commented Oct 30, 2023 •
edited
Loading

  • searches from 1st char
  • can navigate with arrows + tab
  • fixes the empty message (now it appears)
  • some styling modification
  • options are circular mod indexing

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spark-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 8:42am

@andresin87 andresin87 changed the title style: style the search element Search element Oct 30, 2023
@andresin87 andresin87 requested a review from kikoruiz October 31, 2023 08:12
kikoruiz
kikoruiz approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@kikoruiz kikoruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!

@andresin87 andresin87 merged commit 5dcf46c into main Oct 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresz1 andresz1 andresz1 approved these changes

@kikoruiz kikoruiz kikoruiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresin87 @kikoruiz @andresz1