Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixed improvements #15

Merged
merged 9 commits into from
Jun 1, 2016
Merged

Mixed improvements #15

merged 9 commits into from
Jun 1, 2016

Conversation

EmanueleMinotto
Copy link
Member

@EmanueleMinotto EmanueleMinotto commented Mar 31, 2016 •
edited
Loading

This should mark version 1.1

Changes:

  • included a php-cs-fixer configuration (also as a Travis check)
  • Symfony 2.7 as the required minimum version
  • moved sonata-project bundles to stable versions
  • updated documentation

@EmanueleMinotto EmanueleMinotto force-pushed the mixed-improvements branch 4 times, most recently from 3f1d0a2 to 00f0b37 Compare March 31, 2016 23:15
danieledangeli
danieledangeli reviewed May 31, 2016
View reviewed changes
Tests/DependencyInjection/AeFeatureExtensionTest.php
['ae_feature.security.class', 'Ae\FeatureBundle\Security\FeatureSecurity'],
[
'ae_feature.manager.class',
'Ae\FeatureBundle\Entity\FeatureManager',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use FeatureManager::class (we have php 5.5)
It makes sense?

@EmanueleMinotto
Copy link
Member Author

@danieledangeli updated with PHP 5.5 as the minimum required version

@EmanueleMinotto EmanueleMinotto merged commit 3373d12 into master Jun 1, 2016
@EmanueleMinotto EmanueleMinotto deleted the mixed-improvements branch June 1, 2016 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug docs enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmanueleMinotto @danieledangeli