Allow CareFactory fallback to default vehicleType #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As written, the code would set a defualt type on the VehicleFactory prototype but *would not ever use it* because it was overridden in the constructor. This also made switching the default value to Truck in truck factory pointless, as the constructer overrode this as well
|
Thanks for catching this. Landing the fix! |
addyosmani
added a commit
that referenced
this pull request
Mar 16, 2014
Allow CareFactory fallback to default vehicleType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written, the code would set a defualt type on the VehicleFactory prototype but would not ever use it because it is overridden in the constructor. This also made switching the default value to Truck in truck factory pointless, as the constructer overrode this as well