Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds csrf token to action=logout requests #44

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Adds csrf token to action=logout requests #44

merged 1 commit into from
Nov 27, 2019

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented May 14, 2019

@addshore
Copy link
Member

Seem to be a lot of failures :(
But the commit itself looks good?

@addshore addshore requested a review from samwilson May 14, 2019 20:47
@Tpt
Copy link
Contributor Author

Tpt commented May 14, 2019

The CI errors does not seem related to this change.

  • hhvm fails because composer does not support hhvm anymore
  • php 5.* fails because of MediaWiki configuration error (too old PHP version?)
  • php 7.1 fails with PHPUnit_Framework_ExceptionWrapper::__toString() must not throw an exception, caught ParseError: syntax error, unexpected 'const' (T_CONST), expecting variable (T_VARIABLE) in /home/travis/build/addwiki/mediawiki-api-base/vendor/phpunit/phpunit/src/TextUI/ResultPrinter.php on line 0

@samwilson
Copy link
Member

Can we drop hhvm now? And I think the issues with PHP7.1's built-in server are resolved. And can we drop testing on end-of-life MediaWiki versions (we still need to support MW1.27 for another month or so)? I'm having a crack at fixing these in #45.

@addshore
Copy link
Member

addshore commented Jul 9, 2019

Can we drop hhvm now?

I think so

And I think the issues with PHP7.1's built-in server are resolved. And can we drop testing on end-of-life MediaWiki versions (we still need to support MW1.27 for another month or so)? I'm having a crack at fixing these in #45.

Also sounds good!

@addshore
Copy link
Member

I'm going to merge this as it looks fine, need to fix CI at some other time..

@addshore addshore merged commit 5708f00 into master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwilson samwilson Awaiting requested review from samwilson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tpt @addshore @samwilson