Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multipart request #38

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Add multipart request #38

merged 1 commit into from
Oct 10, 2017

Conversation

samwilson
Copy link
Member

@samwilson samwilson mentioned this pull request Oct 3, 2017
Merged
addshore
addshore reviewed Oct 3, 2017
View reviewed changes
src/MultipartRequest.php
* A MultipartRequest is the same as a FluentRequest with additional support for setting request
* parameters (both normal parameters and headers) on multipart requests.
*
* @link http://docs.guzzlephp.org/en/stable/request-options.html#multipart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SInCE please! :D

@addshore
Copy link
Member

addshore commented Oct 3, 2017

Looks good, but needs a rebase and there is 1 comment.

@samwilson
Copy link
Member Author

I've set it as @since 2.4.0, which is the next minor version. Is that correct?

@samwilson
Copy link
Member Author

I've added some docs etc. See what you think now.

@samwilson samwilson requested a review from addshore October 9, 2017 06:41
@addshore addshore merged commit 2eb6350 into addwiki:master Oct 10, 2017
@samwilson samwilson deleted the multipart-requests branch October 10, 2017 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addshore addshore Awaiting requested review from addshore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samwilson @addshore