Allow overriding all Guzzle configuration settings #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $this->assertNull( $client->getConfig('middleware') ); | ||
|
|
||
| $request = $this->getMockBuilder( 'Psr\Http\Message\RequestInterface' )->getMock(); |
There was a problem hiding this comment.
You can use RequestInterface:class
c960657
force-pushed
the
client-factory
branch
from
59eb60c to
d11b623
Compare
addshore
requested changes
Jan 23, 2017
| use Psr\Http\Message\RequestInterface; | ||
|
|
||
| /** | ||
| * @author Addshore |
There was a problem hiding this comment.
Am I the author of this class? ;)
There was a problem hiding this comment.
You are the one that will be blamed for bugs now ;)
| /** | ||
| * @author Addshore | ||
| * | ||
| * @todo test interaction with logger |
There was a problem hiding this comment.
Again I think this comment was probably copied over in error, there isn't much interaction with the logger class in here to test!
c960657
force-pushed
the
client-factory
branch
from
d11b623 to
9f3f28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it possible to override all Guzzle configuration settings, not just user-agent and middleware.