Expose the API URL of MediawikiApi #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just adds MediawikiApi::getApiUrl() as a means to retrieve the API URL. Mostly only useful if you've created an object via MediawikiApi::newFromPage and want to get the URL for use elsewhere.
| * @return string The API URL. | ||
| */ | ||
| public function getApiUrl() | ||
| { |
There was a problem hiding this comment.
This bracket should be on the previous line
There was a problem hiding this comment.
Thanks! :) Which reminds me, we should add phpcs to this package too...
|
bah, looks like the integration tests need to be switched to https :/ |
|
Thanks for the PR @samwilson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds MediawikiApi::getApiUrl() as a means to retrieve
the API URL. Mostly only useful if you've created an object via
MediawikiApi::newFromPage and want to get the URL for use
elsewhere.