Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amends to default course text #3079

Merged
merged 8 commits into from
Mar 23, 2021
Merged

amends to default course text #3079

merged 8 commits into from
Mar 23, 2021

Conversation

moloko
Copy link
Contributor

@moloko moloko commented Mar 17, 2021 •
edited
Loading

resolves #3077

also change <strong> to <b> and <em> to <i> where only being used for formatting

ensure component names are referenced consistently (capitalised and in bold)

@moloko moloko changed the title amends to default course instruction text amends to default course text Mar 17, 2021
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

ghost
ghost approved these changes Mar 18, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

chucklorenz
chucklorenz approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@chucklorenz chucklorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@moloko moloko merged commit 08861f0 into master Mar 23, 2021
@moloko moloko deleted the issue/3077 branch March 23, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@chucklorenz chucklorenz chucklorenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct order of interaction in Narrative mobile instruction
3 participants
@moloko @chucklorenz @cahirodoherty-learningpool