Skip to content

Language Picker breaks tracking.js module completion criteria #2386

Closed
@brian-learningpool

Description

Subject of the issue

When using a multi-language course (with the Language Picker extension enabled), the tracking configuration doesn't correctly set the _completionCriteria from the config.json. This is due

Your environment

  • Adapt Framework v3.5 (though v4 is also affected)
  • Chrome
  • OS X

Steps to reproduce

  1. Create a course with the Language Picker extension enabled and more than one language.
  2. Launch the course and select a language.

Expected behaviour

_completionCriteria would be correctly read from config.json.

Actual behaviour

_completionCriteria is not read. The configModel:loadCourseData event is never fired.

Activity

added a commit that references this issue on Mar 18, 2019

Resolves #2386, switches listeners out for 'configModel:dataLoaded'

1a6bae7
moloko

moloko commented on Mar 19, 2019

@moloko
Contributor

reopening as this needs to be fixed in v3 as well (ideally)

reopened this on Mar 19, 2019
added 2 commits that reference this issue on Mar 19, 2019

Resolves #2386, switches listeners out for 'configModel:dataLoaded'

72f4fd1

Resolves #2386, switches listeners out for 'configModel:dataLoaded' (#…

bdc4a98
brian-learningpool

brian-learningpool commented on Mar 20, 2019

@brian-learningpool
MemberAuthor

Fixed in v3.5.1 and merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Language Picker breaks tracking.js module completion criteria · Issue #2386 · adaptlearning/adapt_framework